Sockopt: Fix some domainStrategy & dialerProxy bugs#4661
Conversation
Closed
RPRX
changed the title
Member
|
|
1 task
maoxikun
added a commit
to maoxikun/Xray-core
that referenced
this pull request
Aug 22, 2025
This reverts commit 1c4e246.
it2konst
pushed a commit
to it2konst/gametunnel-core
that referenced
this pull request
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i fixed these bugs with "happy eyeballs" PR, but @RPRX said to seperate the PRs.
so, after this PR merged, i open new PR for "happy eyeballs".
///
bugs:
ForceIPmode when no ip is found, and wrongly,ForceIPmode was no different fromuseIPmode.(for sockopt-domainStrategy)[also, when
forceIPis set, it shouldn't useAsIsin any situation (whendnsClient == nil) and should return error instead]dialerProxy.(wrongly, you ignoredialerProxyin such a situation and the user mistakenly thought everything was working properly).