Conversation
Member
|
1 应该使用项目内部的errors包 |
Contributor
Author
|
Member
|
这在infra/conf部分处理就行了 我的意思是后面tun.go的部分 |
282836a to
34555e3
Compare
Contributor
Author
|
Fixed to use internal errors package. |
- Replace generic errors with context-rich messages using fmt.Errorf and %w - Add validation for empty WireGuard keys with clear error messages - Implement proper resource cleanup in WireGuard TUN with sync.Once - Add test to verify WireGuard server handles initialization errors without panic
34555e3 to
0ffd7e1
Compare
Member
|
看了下代码,就是加了详细的配置错误说明,Close() 内加了个 sync.Once 类似 quic-go/quic-go#4798 ,加了个 test,可以合并
|
Member
|
我都改了标题 GitHub 还背刺?写 release notes 时还得手动加 first contribution,烦死了我草 |
RPRX
pushed a commit
that referenced
this pull request
Mar 30, 2025
…rors during server initialization (#4566) #4566 (comment)
1 task
maoxikun
pushed a commit
to maoxikun/Xray-core
that referenced
this pull request
Aug 23, 2025
…rors during server initialization (XTLS#4566) XTLS#4566 (comment) (cherry picked from commit 17207fc)
it2konst
pushed a commit
to it2konst/gametunnel-core
that referenced
this pull request
Mar 1, 2026
…rors during server initialization (XTLS#4566) XTLS#4566 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request:
Overall, this leads to much better user experience in case of misconfiguration