Skip to content

Test: Change address for DNS over QUIC tests#4002

Merged
yuhan6665 merged 1 commit intoXTLS:mainfrom
zonescape:adguard
Nov 11, 2024
Merged

Test: Change address for DNS over QUIC tests#4002
yuhan6665 merged 1 commit intoXTLS:mainfrom
zonescape:adguard

Conversation

@zonescape
Copy link
Contributor

@zonescape zonescape commented Nov 11, 2024

My ISP blocks *.adguard.com so DNS over QUIC test results look like this:

$ go test github.com/xtls/xray-core/app/dns

...

--- FAIL: TestQUICNameServer (2.00s)
panic: context deadline exceeded [recovered]
	panic: context deadline exceeded

goroutine 356 [running]:
testing.tRunner.func1.2({0xb931c0, 0x129f360})
	/usr/local/go/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1634 +0x377
panic({0xb931c0?, 0x129f360?})
	/usr/local/go/src/runtime/panic.go:770 +0x132
github.com/xtls/xray-core/common.Must(...)
	/Xray-core/common/common.go:21
github.com/xtls/xray-core/app/dns_test.TestQUICNameServer(0xc0000eed00)
	/Xray-core/app/dns/nameserver_quic_test.go:27 +0x2ca
testing.tRunner(0xc0000eed00, 0xc89b80)
	/usr/local/go/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 1
	/usr/local/go/src/testing/testing.go:1742 +0x390
FAIL	github.com/xtls/xray-core/app/dns	10.338s
FAIL

This can be currently fixed by changing domain name from dns.adguard.com to dns.adguard-dns.com but I am not sure it will work everywhere.

UPDATE

The reason of blocking is AdGuard VPN. AdGuard DNS is collateral damage. As far as I understand *.adguard-dns.com is now used exclusively for the DNS service. So it is safe to use it for now.

Official list of AdGuard DNS servers.

dns.adguard.com can be blocked in some places
@Fangliding
Copy link
Member

¿

@wyx2685
Copy link
Contributor

wyx2685 commented Nov 11, 2024

兄弟是来搞笑的吗

@zonescape
Copy link
Contributor Author

兄弟是来搞笑的吗
[EN] Are you kidding me?

Yeah, it's funny when tests in a censorship circumvention tool fail because of censorship. But even without censorship tests that depend on the outside world sometimes have to be fixed not because the code under test changes, but because the outside world changes. The best solution would be to write tests that don't depend on the outside world.

@yuhan6665 yuhan6665 changed the title Fix DNS over QUIC tests (my ISP blocks *.adguard.com) Test: Change address for DNS over QUIC tests Nov 11, 2024
@yuhan6665 yuhan6665 merged commit 44b1dd0 into XTLS:main Nov 11, 2024
@yuhan6665
Copy link
Member

Accepted

it2konst pushed a commit to it2konst/gametunnel-core that referenced this pull request Mar 1, 2026
dns.adguard.com can be blocked in some places
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants