Skip to content

Fix: Return error when Fingerprint does not support TLS 1.3#3774

Merged
yuhan6665 merged 1 commit intomainfrom
REALITY-TLS12-Warning
Sep 9, 2024
Merged

Fix: Return error when Fingerprint does not support TLS 1.3#3774
yuhan6665 merged 1 commit intomainfrom
REALITY-TLS12-Warning

Conversation

@Fangliding
Copy link
Member

@Fangliding Fangliding commented Sep 8, 2024

在尝试解决 #2896 的时候 稍微调试了一下,发现 uConn.HandshakeState.State13.EcdheKey 竟然是nil, 调查后发现 utls 的安卓11指纹(实为OkHttp)是仅TLS 1.2的 (见 https://github.com/refraction-networking/utls/blob/23de245734c7c25b11200f8b5859c2114c032e51/u_parrots.go#L1595 因为它没有 SupportedVersionsExtension 扩展) 连TLS1.3都不是 EcdheKey 自然就是nil了 继续尝试调用其ECDH方法自然就导致了空指针panic
我认为这是utls库的一个错误,因为OkHttp在安卓10就默认使用了TLS13 不过考虑到可能还有其他仅TLS12的指纹 被random到踩到坑 还是在Xray这边检测并返回错误 避免直接panic比较好
闲的话可以把服务器证书换成GTS签发的 然后用android指纹 会因为使用TLS12导致证书泄露 GFW看到GTS的证书就会把服务器IP阻断几分钟 我本地测试的时候发现的

@RPRX
Copy link
Member

RPRX commented Sep 9, 2024

我认为这是utls库的一个错误,因为OkHttp在安卓10就默认使用了TLS13

其实我也觉得只支持 TLSv1.2 的话有点怪,@gaukas 看一下?

@Fangliding
Copy link
Member Author

我认为这是utls库的一个错误,因为OkHttp在安卓10就默认使用了TLS13

其实我也觉得只支持 TLSv1.2 的话有点怪,@gaukas 看一下?

我已经在utls提交一个issue询问了 它确实是1.2 已经漏了证书让我服务器挨墙了 尝试捕获错误避免panic肯定是没问题的(

@yuhan6665 yuhan6665 changed the title 在 Fingerprint 选项不支持TLS 1.3时捕获错误 Fix: Return error when Fingerprint does not support TLS 1.3 Sep 9, 2024
@yuhan6665 yuhan6665 merged commit 3d0feae into main Sep 9, 2024
@yuhan6665
Copy link
Member

Thank for the great investigation!

@Fangliding Fangliding deleted the REALITY-TLS12-Warning branch September 9, 2024 16:11
@RPRX
Copy link
Member

RPRX commented Oct 6, 2024

这个也是 PR 标题改了但 commit title 没改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants