convert common.js modules to new standard ESM module syntax #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What did you use to do this conversion? |
|
A few regex find and replaces did most of the work, and then the |
|
🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js, Browser Vendors, and the rest of the JS ecosystem are moving towards a standard module syntax for JavaScript. It's "strict" by default, standard across environments, and easier for compilers to optimize for.
Why now? This work is driven by our switch from Flow to TypeScript, so that we can add powerful typing support to our new API request interface. TypeScript uses ESM exclusively, so this is the first step. See #812 for more info.
No changes to Babel were needed, it successfully compiles down to Node-style common.js modules for distribution. Tests continue to pass.
/cc @intelliot