Fix ledger_entry crash on invalid request #5189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
RPC
ledger_entry
is not performing sufficient checks on input fordeposit_preauth
, which causes a crash.Context of Change
In #5103 we have added support for
authorized_credentials
array todeposit_preauth
objects for theledger_entry
RCP request. The checks for the correct inputs in thisauthorized_credentials
array were not exhaustive enough. This PR is fixing it, alongside with fixing the unit tests to improve the coverage.Type of Change
.gitignore
, formatting, dropping support for older tooling)