Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unity build #5179

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix unity build #5179

merged 1 commit into from
Nov 5, 2024

Conversation

gregtatcam
Copy link
Collaborator

High Level Overview of Change

Fix unity build. Added namespace test to address the issue.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.6%. Comparing base (54a350b) to head (1bcafa0).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5179     +/-   ##
=========================================
- Coverage     77.6%   77.6%   -0.0%     
=========================================
  Files          779     779             
  Lines        65976   65976             
  Branches      8168    8171      +3     
=========================================
- Hits         51190   51182      -8     
- Misses       14786   14794      +8     

see 4 files with indirect coverage changes

Impacted file tree graph

@yinyiqian1 yinyiqian1 requested review from yinyiqian1 and removed request for yinyiqian1 November 5, 2024 01:18
@ximinez ximinez merged commit d57cced into XRPLF:develop Nov 5, 2024
20 checks passed
vlntb pushed a commit to vlntb/rippled that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants