-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixAMMv1_2 amendment #5176
Add fixAMMv1_2 amendment #5176
Conversation
* Add reserve check on AMM Withdraw * Try AMM max offer if changeSpotPriceQuality() fails
49e68e4
to
c60d273
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5176 +/- ##
=========================================
- Coverage 77.6% 77.6% -0.0%
=========================================
Files 779 779
Lines 65975 66006 +31
Branches 8170 8172 +2
=========================================
+ Hits 51187 51211 +24
- Misses 14788 14795 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Normally these checks are supposed to use the "prior balance", i.e. the balance of the account before the transaction started executing. I just want to note that we're making an exception here. In fact, it would be easier if we could ignore the "prior balance" everywhere. The context for most helper functions is just the |
Co-authored-by: Ed Hennis <[email protected]>
* Add reserve check on AMM Withdraw * Try AMM max offer if changeSpotPriceQuality() fails
High Level Overview of Change
Add fixAMMv1_2 amendment:
Type of Change
.gitignore
, formatting, dropping support for older tooling)Test Plan
Added unit test to check reserve requirements on AMMWithdraw.