Add hubs.xrpkuwait.com to bootstrap #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloynetworks
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5169 +/- ##
=========================================
- Coverage 77.5% 77.5% -0.0%
=========================================
Files 777 777
Lines 65831 65832 +1
Branches 8184 8207 +23
=========================================
- Hits 51026 50996 -30
- Misses 14805 14836 +31
... and 7 files with indirect coverage changes |
ximinez
approved these changes
Oct 30, 2024
bachase
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Thanks @Xrpkuwait for your commitment to run this infrastructure, and thanks @alloynetworks for your help.
|
@alloynetworks Since this has two passing reviews, please affirmatively indicate that it's ready to merge by adding the "Passing" label, or leaving a comment to that effect. |
alloynetworks
added
the
Passed
vlntb
pushed a commit
to vlntb/rippled
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hubs.xrpkuwait.com to default bootstrap and update example rippled.cfg file. Combines 5166 and 5167