-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intrusive shamap inner final #5152
Open
vlntb
wants to merge
42
commits into
XRPLF:develop
Choose a base branch
from
vlntb:intrusive_shamap_inner_final
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,365
−719
Open
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
3f07882
Split tagged cache into .h and .ipp files cc
da72b7d
[remove] Scripts to measure and plot memory savings
da2ba2f
Replace SHAMapTreeNodes with intrusive pointers:
136db4f
[fold] Replace jthread with thread (mac does not have jthread yet)
19464a0
adding missing headers
vlntb c0659ff
[remove] Temporary change to measure maximum strong and weak referenc…
vlntb c20d442
[remove] Temporary change to measure max ref counts when switching fr…
vlntb f68dda8
[remove] stack trace printout
vlntb 785fefc
sync with develop
vlntb aa1022d
clang-reformat
vlntb 392ded3
clang-reformat
vlntb 2510c2d
resolve levelization issues
vlntb f54e434
trigger GitHub actions
vlntb a2fa231
revert stack trace printout
vlntb 82af26a
revert Temporary change to measure max ref counts when switching from…
vlntb d607e78
revert Temporary change to measure maximum strong and weak reference …
vlntb 5819fa6
revert Scripts to measure and plot memory savings
vlntb 4b875e9
inlining template functions
vlntb 666d9ea
addressing review comments #1
vlntb ce3e00f
addressing review comments
vlntb 8c27b3a
addressing review comments
vlntb ac9ef08
addressing review comments
vlntb 3f8ab63
code cleanup
vlntb 0050eab
Merge branch 'develop' into intrusive_shamap_inner_final
vlntb 3beaa43
fixing ValueEntry checks based on the combined shared and weak
vlntb 1fa8519
Merge branch 'develop' into intrusive_shamap_inner_final
vlntb 5a1790b
sync with develop
vlntb d8588d0
new ASSERTs for Antithesis
vlntb d610533
moving to structured bindings
vlntb cc2563f
Addressing review comments #1
vlntb f9650ea
Addressing review comments #2
vlntb f54fb8f
Addressing review comments #3
vlntb 5bdab50
messages in ASSERTS
vlntb 0b613fe
clang-format
vlntb 0df59d4
Merge branch 'develop' into intrusive_shamap_inner_final
vlntb a5ccaf5
Revert "moving to structured bindings"
vlntb eefdb89
sync with develop
vlntb 6aa0a0a
fixed special case in isWeak
vlntb 4d5f016
Merge branch 'develop' into intrusive_shamap_inner_final
vlntb 2cdabe6
removed formatter override
vlntb f371d88
adding comment
vlntb da54c14
Merge branch 'develop' into intrusive_shamap_inner_final
vlntb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
addressing review comments
commit ac9ef08be5b7b9105edd45335a2e13e7a05a1017
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this check is redundant since union1 was assigned strong2 in test 1) Normal assignment