Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BUILD.md after PR 5052 #5067

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Update BUILD.md after PR 5052 #5067

merged 3 commits into from
Jul 23, 2024

Conversation

dangell7
Copy link
Collaborator

@dangell7 dangell7 commented Jul 16, 2024

High Level Overview of Change

Added the -Dxrpld=TRUE -Dtests=TRUE cmake flags to the BUILD.md steps. After PR #5052 I was not able to build rippled.

ninja: error: unknown target 'rippled'

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.3%. Comparing base (f3bcc65) to head (1178e39).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5067   +/-   ##
=======================================
  Coverage     71.3%   71.3%           
=======================================
  Files          796     796           
  Lines        67031   67031           
  Branches     10885   10885           
=======================================
+ Hits         47808   47811    +3     
+ Misses       19223   19220    -3     

see 5 files with indirect coverage changes

Impacted file tree graph

BUILD.md Outdated Show resolved Hide resolved
BUILD.md Outdated Show resolved Hide resolved
Co-authored-by: Ed Hennis <[email protected]>
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a relatively small change only to documentation, what do you think about treating this PR as trivial, so it only needs one approval?

@ximinez
Copy link
Collaborator

ximinez commented Jul 23, 2024

@dangell7 This now has two approvals. If you think it's ready to merge, please indicate such by putting the "Passed" label on it, or leaving a comment here to that effect.

@dangell7
Copy link
Collaborator Author

@ximinez Ah yes, I think treating this as trivial makes sense. Ready for merge.

@ximinez ximinez added Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Documentation README changes, code comments, etc. Perf impact not expected Change is not expected to improve nor harm performance. labels Jul 23, 2024
@ximinez ximinez added this to the 2.3.0 (August 2024) milestone Jul 23, 2024
@ximinez ximinez merged commit ad14d09 into XRPLF:develop Jul 23, 2024
19 of 20 checks passed
vlntb pushed a commit to vlntb/rippled that referenced this pull request Aug 23, 2024
* Document the need to specify "xrpld" and "tests" to build and test rippled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation README changes, code comments, etc. Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Perf impact not expected Change is not expected to improve nor harm performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants