-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BUILD.md after PR 5052 #5067
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5067 +/- ##
=======================================
Coverage 71.3% 71.3%
=======================================
Files 796 796
Lines 67031 67031
Branches 10885 10885
=======================================
+ Hits 47808 47811 +3
+ Misses 19223 19220 -3 |
Co-authored-by: Ed Hennis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a relatively small change only to documentation, what do you think about treating this PR as trivial, so it only needs one approval?
@dangell7 This now has two approvals. If you think it's ready to merge, please indicate such by putting the "Passed" label on it, or leaving a comment here to that effect. |
@ximinez Ah yes, I think treating this as trivial makes sense. Ready for merge. |
* Document the need to specify "xrpld" and "tests" to build and test rippled.
High Level Overview of Change
Added the
-Dxrpld=TRUE -Dtests=TRUE
cmake flags to the BUILD.md steps. After PR #5052 I was not able to buildrippled
.ninja: error: unknown target 'rippled'
Context of Change
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)