chore: Rename two files from Directory* to Dir*: #5058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The names of the files should reflect the name of the Dir class.
scottschurr
added
Tech Debt
scottschurr
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5058 +/- ##
=========================================
- Coverage 71.4% 71.4% -0.0%
=========================================
Files 796 796
Lines 67031 67031
Branches 10865 10866 +1
=========================================
- Hits 47833 47828 -5
- Misses 19198 19203 +5
... and 4 files with indirect coverage changes |
zrayn
approved these changes
Jul 9, 2024
|
I requested @thejohnfreeman as a reviewer to make sure that I did not break some aspect of the build when I renamed the two files. John has directly confirmed to me that renaming those files should have no impact on the CMake stuff as it is currently structured. So I think that takes John off the hook as a reviewer. Thanks John! |
thejohnfreeman
approved these changes
Jul 13, 2024
ximinez
approved these changes
Jul 24, 2024
|
@scottschurr This PR now has two approvals. If you think it's ready to merge, please add the "Passed" label, or write a comment to that effect. |
scottschurr
added
the
Passed
vlntb
pushed a commit
to vlntb/rippled
that referenced
this pull request
Aug 23, 2024
The names of the files should reflect the name of the Dir class. Co-authored-by: Zack Brunson <[email protected]> Co-authored-by: Ed Hennis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The
Dirclass was contained in two files namedDirectory.handDirectory.cpp. The files are renamedDir.handDir.cppto reflect the class that they contain. Additionally:Directory.hhave been removed andDirclass has been added.Type of Change