Add xrpl.libpb
as an exported lib
#5022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Tiny change to export
libpb
so that consumers oflibxrpl
can link against it again.Context of Change
Clio could not link against
libxrpl
produced from the current code.The reason seems to be that
libpb
was not exported and consequently did not make it into the linked libraries despite being publicly linked thru thexrpl::libxrpl
target in cmake.Type of Change
API Impact
None other than being able to link against libxrpl as a consumer.
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)