Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xrpl.libpb as an exported lib #5022

Merged
merged 2 commits into from
May 20, 2024

Conversation

godexsoft
Copy link
Collaborator

@godexsoft godexsoft commented May 20, 2024

High Level Overview of Change

Tiny change to export libpb so that consumers of libxrpl can link against it again.

Context of Change

Clio could not link against libxrpl produced from the current code.
The reason seems to be that libpb was not exported and consequently did not make it into the linked libraries despite being publicly linked thru thexrpl::libxrpl target in cmake.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

API Impact

None other than being able to link against libxrpl as a consumer.

  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)

@godexsoft godexsoft changed the title Add xrpl.libpp as an exported lib Add xrpl.libpb as an exported lib May 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.1%. Comparing base (f2d37da) to head (9bcfc85).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5022   +/-   ##
=======================================
  Coverage     71.1%   71.1%           
=======================================
  Files          796     796           
  Lines        66997   66997           
  Branches     10980   10978    -2     
=======================================
+ Hits         47634   47636    +2     
+ Misses       19363   19361    -2     

see 2 files with indirect coverage changes

Impacted file tree graph

@seelabs seelabs merged commit 0c971b4 into XRPLF:develop May 20, 2024
17 checks passed
@seelabs seelabs mentioned this pull request May 20, 2024
1 task
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants