Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMM Unit tests: rounding down of equal asset deposit LPToken calculation #4982

Merged
merged 12 commits into from
Apr 18, 2024
Merged

AMM Unit tests: rounding down of equal asset deposit LPToken calculation #4982

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e734403
AMM Unit tests: rounding down of equal asset deposit LPToken calculation
ckeshava Apr 4, 2024
7542e72
simplify the numbers used in unit test
ckeshava Apr 5, 2024
2db3500
fix clang format
ckeshava Apr 5, 2024
16a6515
Enable all unit tests
ckeshava Apr 5, 2024
bf1712a
Merge branch 'develop' of https://github.com/XRPLF/rippled into rd
ckeshava Apr 5, 2024
015c5cd
Merge branch 'rd' of https://github.com/ckeshava/rippled into rd
ckeshava Apr 5, 2024
0d357c9
Rectify numbers to trigger rounding down
ckeshava Apr 5, 2024
31b8971
remove an inaccurate comment
ckeshava Apr 5, 2024
5302b30
explanatory comment to indicate the rounding down of LPTokens and amo…
ckeshava Apr 9, 2024
13244e8
[FOLD] include an assert check to validate rounding down behavior
ckeshava Apr 9, 2024
7e9f708
Merge branch 'develop' into rd
ximinez Apr 18, 2024
8f7dbfb
Merge branch 'develop' into rd
ximinez Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions src/test/app/AMM_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4934,30 +4934,30 @@ struct AMM_test : public jtx::AMMTest
void
testCore()
{
testInvalidInstance();
testInstanceCreate();
testInvalidDeposit();
// testInvalidInstance();
// testInstanceCreate();
// testInvalidDeposit();
testDeposit();
testInvalidWithdraw();
testWithdraw();
testInvalidFeeVote();
testFeeVote();
testInvalidBid();
testBid();
testInvalidAMMPayment();
testBasicPaymentEngine();
testAMMTokens();
testAmendment();
testFlags();
testRippling();
testAMMAndCLOB();
testTradingFee();
testAdjustedTokens();
testAutoDelete();
testClawback();
testAMMID();
testSelection();
testFixDefaultInnerObj();
// testInvalidWithdraw();
// testWithdraw();
// testInvalidFeeVote();
// testFeeVote();
// testInvalidBid();
// testBid();
// testInvalidAMMPayment();
// testBasicPaymentEngine();
// testAMMTokens();
// testAmendment();
// testFlags();
// testRippling();
// testAMMAndCLOB();
// testTradingFee();
// testAdjustedTokens();
// testAutoDelete();
// testClawback();
// testAMMID();
// testSelection();
// testFixDefaultInnerObj();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment out all of the tests?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, fixed it

}

void
Expand Down
Loading