Revert "Asynchronously write batches to NuDB. (#4503)" #4882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1d9db1b.
High Level Overview of Change
Revert code that introduces problems associated with online deletion.
Context of Change
The bug was introduced in PR #4503, which causes writes to block during online deletion. In turn, this delays persisting records to disk during consensus, which causes node desyncs.
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)Run online deletion as normal. It should stay stable, and revert to behavior from 1.12 and previous.
Future Tasks
If we proceed with this revert, there will there be no reason to consider #4762.
Closes #4762