Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Asynchronously write batches to NuDB. (#4503)" #4882

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

mtrippled
Copy link
Collaborator

@mtrippled mtrippled commented Jan 16, 2024

This reverts commit 1d9db1b.

High Level Overview of Change

Revert code that introduces problems associated with online deletion.

Context of Change

The bug was introduced in PR #4503, which causes writes to block during online deletion. In turn, this delays persisting records to disk during consensus, which causes node desyncs.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Run online deletion as normal. It should stay stable, and revert to behavior from 1.12 and previous.

Future Tasks

If we proceed with this revert, there will there be no reason to consider #4762.

Closes #4762

@intelliot
Copy link
Collaborator

QA will check to see how this can be tested

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean revert.

@intelliot
Copy link
Collaborator

Internal tracker: RPFC-80

@intelliot intelliot added the Perf SignedOff RippleX Performance Team has approved label Jan 19, 2024
@intelliot
Copy link
Collaborator

Perf SignedOff: "I think 4882 is good to go"

@intelliot intelliot merged commit a41f385 into XRPLF:develop Jan 19, 2024
16 checks passed
@intelliot intelliot mentioned this pull request Jan 22, 2024
1 task
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
This reverts commit 1d9db1b.

This improves the stability of online deletion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf SignedOff RippleX Performance Team has approved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants