Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLS-52d: NFTokenMintOffer #4845

Merged
merged 24 commits into from
Jun 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
df092fc
NFTokenMIntOffer initial
tequdev Nov 19, 2023
351c135
clang-format
tequdev Nov 19, 2023
dc525c1
Merge commit '06251aa76f5cff9a546107432d959e09a7a93f29' into featureN…
tequdev Dec 1, 2023
650af48
clang-format
tequdev Dec 1, 2023
c517ae9
Merge branch 'develop' into featureNFTokenMintOffer
tequdev Dec 5, 2023
5815a57
Update Feature.h
tequdev Dec 5, 2023
f9e4cda
Update NFToken_test.cpp
tequdev Dec 5, 2023
a7f374e
fix sfAmount field
tequdev Dec 5, 2023
22aaf09
Merge branch 'develop' into featureNFTokenMintOffer
tequdev Dec 13, 2023
2321b8c
Merge commit '901152bd930447720ca4e738a10ffd878f401a53' into featureN…
tequdev Jan 25, 2024
b8954f4
fix expiration, reserve, offer_id meta
tequdev Jan 31, 2024
e48768d
clang-format
tequdev Jan 31, 2024
b89fdd6
Merge branch 'develop' into featureNFTokenMintOffer
tequdev Jan 31, 2024
65d62df
Add test for trustline, disallowincoming
tequdev Feb 1, 2024
329729c
Merge branch 'develop' into featureNFTokenMintOffer
tequdev Feb 1, 2024
95b2e08
fix duplicate error handling
tequdev Feb 1, 2024
6ff088e
Merge commit '828bb64ebc76394cf9a3f7edd42f4588d106932f' into featureN…
tequdev Feb 5, 2024
bb73021
Merge remote-tracking branch 'upstream/develop' into featureNFTokenMi…
tequdev Feb 13, 2024
ffef12c
Merge commit 'af9cabe1001e9489f95ceea5f4ab4d079a1488f9' into featureN…
tequdev Mar 14, 2024
6e0d26f
Addressing Reviews
tequdev Mar 14, 2024
f65eea7
fix same as fixNFTokenTrustlineSurprise
tequdev Mar 15, 2024
fe4d616
[FOLD] Refactor NFTokenMint and NFTokenCreateOffer to share code
scottschurr Apr 29, 2024
590218b
Merge commit '40b4adc9cc296a7e3c6e8c94b5a977a54c835613' into featureN…
tequdev May 21, 2024
7bc8302
Merge branch 'develop' into featureNFTokenMintOffer
seelabs Jun 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ripple/app/tx/impl/NFTokenMint.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,10 @@ NFTokenMint::preclaim(PreclaimContext const& ctx)
auto const nftIssuer =
ctx.tx[~sfIssuer].value_or(ctx.tx[sfAccount]);

if (!ctx.view.exists(keylet::line(nftIssuer, amount->issue())))
// If the IOU issuer and the NFToken issuer are the same,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should be prefixed with [FOLD] to indicate that this commit should be merged (likely with the previous commit).

// then that issuer does not need a trust line to accept their fee.
if (nftIssuer != amount->getIssuer() &&
!ctx.view.read(keylet::line(nftIssuer, amount->issue())))
return tecNO_LINE;

if (isFrozen(
Expand Down
9 changes: 9 additions & 0 deletions src/test/app/NFToken_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6707,6 +6707,15 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
env.close();
BEAST_EXPECT(ownerCount(env, alice) == 0);

// If the IOU issuer and the NFToken issuer are the same,
// then that issuer does not need a trust line to accept their
// fee.
env(token::mint(gw),
token::amount(gwAUD(1000)),
txflags(tfTransferable),
token::xferFee(10));
env.close();

// Give alice the needed trust line, but freeze it.
env(trust(gw, alice["AUD"](999), tfSetFreeze));
env.close();
Expand Down
Loading