Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging release back to develop #4819

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Merging release back to develop #4819

merged 1 commit into from
Nov 28, 2023

Conversation

manojsdoshi
Copy link
Contributor

No description provided.

ximinez
ximinez approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is the same code I just approved in #4818 , I'll approve it here, too.

scottschurr
scottschurr approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Builds, passes unit tests, and syncs for me on macOS.

@intelliot intelliot merged commit 8ec475b into XRPLF:develop Nov 28, 2023
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottschurr scottschurr scottschurr approved these changes

@ximinez ximinez ximinez approved these changes

@intelliot intelliot Awaiting requested review from intelliot

@seelabs seelabs Awaiting requested review from seelabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manojsdoshi @ximinez @scottschurr @intelliot