[TRIVIAL] Workarounds for gcc-13 compatibility #4817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bronek
force-pushed
the
feature/gcc-13
branch
from
ca2d060
to
5c98061
Compare
seelabs
approved these changes
Nov 30, 2023
Bronek
force-pushed
the
feature/gcc-13
branch
from
5c98061
to
ca86873
Compare
Bronek
changed the title
|
Merged due to request from Bronek and because the change is trivial. |
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
Workaround for compilation errors with gcc-13 and other compilers relying on `libstdc++` version 13. This is temporary until actual fix is available for us to use: boostorg/beast#2682 Some boost.beast files (which we do use) rely on an old gcc-12 behaviour where `#include <cstdint>` was not needed even though types from this header were used. This was broken by a change in libstdc++ version 13: https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes The necessary fix was implemented in boost.beast, however it is not yet available. Until it is available, we can use this workaround to enable compilation of `rippled` with gcc-13, clang-16, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Workaround for compilation errors with gcc-13 and other compilers relying on
libstdc++version 13This is temporary until actual fix boostorg/beast#2682 is available for us to use.
Context of Change
Some boost.beast files (which we do use) rely on an old gcc-12 behaviour where
#include <cstdint>was not needed even though types from this header were used. This was broken by change in libstdc++ version 13 https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes . The necessary fix was implemented in boost.beast in boostorg/beast#2682 however it is not yet available. Until it is available we can use this workaround to enable compilation ofrippledwith gcc-13, clang-16 etc.Type of Change
.gitignore, formatting, dropping support for older tooling)