Promote API version 2 to supported #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bronek
force-pushed
the
feature/promote_API_V2_to_supported
branch
2 times, most recently
from
fd7e0db to
3801410
Compare
ximinez
requested changes
Nov 6, 2023
Bronek
force-pushed
the
feature/promote_API_V2_to_supported
branch
from
271ad5c to
bdb123d
Compare
ximinez
approved these changes
Nov 7, 2023
This method is not implemented, the only parts which are removed are related to command-line parsing
Bronek
force-pushed
the
feature/promote_API_V2_to_supported
branch
from
bdb123d to
9865328
Compare
ckniffen
reviewed
Nov 8, 2023
| @@ -131,7 +131,16 @@ else () | |||
| >) | |||
| endif () | |||
|
|
|||
| if (use_gold AND is_gcc) | |||
| if (use_mold) | |||
There was a problem hiding this comment.
Were these changes required to allow version 2?
manojsdoshi
added a commit
that referenced
this pull request
Nov 20, 2023
* Support for the mold linker (#4807) * Promote API version 2 to supported (#4803) * Promote API version 2 to be supported * Switch the command line to API version 1 * Fix LedgerRequestRPC test * Remove obsolete tx_account method This method is not implemented, the only parts which are removed are related to command-line parsing * Fix RPCCall test * Reduce diff size, small test improvements * Minor fixes * Support for the mold linker * Fix TransactionEntry_test * Fix AccountTx_test --------- Co-authored-by: seelabs <[email protected]> * Update Linux smoketest distros (#4813) * Fix 2.0 regression in tx method with binary output (#4812) * Fix binary output from tx method * Formatting fix * Minor test improvement * Minor test improvements * Optimize calculation of close time to avoid impasse and minimize gratuitous proposal changes (#4760) * Optimize the calculation of close time to avoid impasse and minimize gratuitous proposal changes. * git apply clang-format.patch * Scott S review fixes. Also clang-format. * Set version to 2.0.0-rc2 --------- Co-authored-by: manoj <[email protected]> Co-authored-by: Scott Determan <[email protected]> Co-authored-by: Bronek Kozicki <[email protected]> Co-authored-by: Michael Legleux <[email protected]> Co-authored-by: Mark Travis <[email protected]>
ximinez
pushed a commit
to ximinez/rippled
that referenced
this pull request
Nov 21, 2023
* Promote API version 2 to supported * Switch command line to API version 1 * Fix LedgerRequestRPC test * Remove obsolete tx_account method This method is not implemented, the only parts which are removed are related to command-line parsing * Fix RPCCall test * Reduce diff size, small test improvements * Minor fixes * Support for the mold linker * [fold] handle case where both mold and gold are installed * [fold] Use first non-default linker * Fix TransactionEntry_test * Fix AccountTx_test --------- Co-authored-by: seelabs <[email protected]>
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Nov 21, 2023
* Promote API version 2 to supported * Switch command line to API version 1 * Fix LedgerRequestRPC test * Remove obsolete tx_account method This method is not implemented, the only parts which are removed are related to command-line parsing * Fix RPCCall test * Reduce diff size, small test improvements * Minor fixes * Support for the mold linker * [fold] handle case where both mold and gold are installed * [fold] Use first non-default linker * Fix TransactionEntry_test * Fix AccountTx_test --------- Co-authored-by: seelabs <[email protected]>
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
* Promote API version 2 to supported * Switch command line to API version 1 * Fix LedgerRequestRPC test * Remove obsolete tx_account method This method is not implemented, the only parts which are removed are related to command-line parsing * Fix RPCCall test * Reduce diff size, small test improvements * Minor fixes * Support for the mold linker * [fold] handle case where both mold and gold are installed * [fold] Use first non-default linker * Fix TransactionEntry_test * Fix AccountTx_test --------- Co-authored-by: seelabs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR version essentially bumps
apiMaximumSupportedVersionto 2, whilst ensuring that the command line interface (bothrippledand the one used in unit tests) stays at version 1. We plan to bump the command line interface to API version 2, but not in this PR (probably also not in the nearest release). We also bumpapiBetaVersionto 3 and addapiCommandLineVersion, used by both command line parsing and these unit tests which rely on command line parsing.Note, this change removes remnants of a non-functional method
tx_account. The method has no implementation and no mapping inHandler.cpp, however until this PR it did have command line parsing (only used in unit tests and otherwise useless). This is now removed.Large diff is result of the switch to
forAllApiVersionsinRPCall_test.cpp. This test was failing because of hardcoded dependency onapiMaximumSupportedVersion(which before this change was incidentally the same asapiMinimumSupportedVersion), expressed both as%MAX_API_VER%and as a conditional on expected output (near lines 1353 - 1369). Since change was needed to fix the failing test, and large diff would be unavoidable to remove the misleading%MAX_API_VER%name, I decided to do it whilst improving test design and coverage.Type of Change
.gitignore, formatting, dropping support for older tooling)