Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for valid public key in attestations #4798

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix: check for valid public key in attestations #4798

merged 1 commit into from
Nov 2, 2023

Conversation

seelabs
Copy link
Collaborator

@seelabs seelabs commented Nov 2, 2023

  • [x ] Bug fix (non-breaking change which fixes an issue)

pwang200
pwang200 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@pwang200 pwang200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

scottschurr
scottschurr approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seelabs seelabs added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Nov 2, 2023
@intelliot intelliot merged commit 09e0f10 into XRPLF:develop Nov 2, 2023
16 checks passed
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
@seelabs @sophiax851
fix: check for valid public key in attestations (XRPLF#4798)
9fc4f7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottschurr scottschurr scottschurr approved these changes

@pwang200 pwang200 pwang200 approved these changes

Assignees
No one assigned
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seelabs @pwang200 @scottschurr @intelliot