Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] fix clang unused-but-set-variable warning #4677

Merged
merged 2 commits into from
Oct 31, 2023
Merged

[TRIVIAL] fix clang unused-but-set-variable warning #4677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c321f5
Trivial: fix unused-but-set-variable warning
StefanVK Aug 27, 2023
49f518c
Merge branch 'develop' into fix_clang_warning
intelliot Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/ripple/app/rdb/backend/impl/PostgresDatabase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,6 @@ loadLedgerInfos(
"total_coins, closing_time, prev_closing_time, close_time_res, "
"close_flags, ledger_seq FROM ledgers ";

uint32_t expNumResults = 1;

if (auto ledgerSeq = std::get_if<uint32_t>(&whichLedger))
{
sql << "WHERE ledger_seq = " + std::to_string(*ledgerSeq);
Expand All @@ -189,8 +187,6 @@ loadLedgerInfos(
auto minAndMax =
std::get_if<std::pair<uint32_t, uint32_t>>(&whichLedger))
{
expNumResults = minAndMax->second - minAndMax->first;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it useful to assert the validity of the output of the Postgres database?
expNumResults could be set to an initial absurd value (say -1), later we can do:

if(expNumResults != -1)
    assert(expNumResults == res.ntuples());

Similar to the validation at

rippled/src/ripple/app/rdb/backend/impl/PostgresDatabase.cpp

Line 223 in 3c321f5

if (res.isNull() || res.ntuples() == 0)

Is this useful?


sql
<< ("WHERE ledger_seq >= " + std::to_string(minAndMax->first) +
" AND ledger_seq <= " + std::to_string(minAndMax->second));
Expand Down
Loading