Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] fix typo in SECURITY.md #4662

Merged
merged 6 commits into from
Oct 4, 2023
Merged

[TRIVIAL] fix typo in SECURITY.md #4662

merged 6 commits into from
Oct 4, 2023

Conversation

sokkaofthewatertribe
Copy link
Contributor

noticed a minor typo while reviewing security.md

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. (I've changed the title of this PR to tag it as "trivial", which allows it to be merged with only one approval.)

@ximinez ximinez changed the title fix typo in SECURITY.md [TRIVIAL] fix typo in SECURITY.md Aug 17, 2023
@intelliot intelliot added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Aug 18, 2023
@sokkaofthewatertribe
Copy link
Contributor Author

No problem, thanks @ximinez

@sokkaofthewatertribe
Copy link
Contributor Author

Hey @intelliot - I noticed that merging this PR is blocked because the initial commit was not signed. Should I open a new PR with a signed commit, or are you still able to merge?

SECURITY.md Outdated Show resolved Hide resolved
@intelliot
Copy link
Collaborator

Should I open a new PR with a signed commit, or are you still able to merge?

There's no need to open a new PR to sign the commits; you can sign and force-push to your existing branch, which will update this PR.

@intelliot
Copy link
Collaborator

Merging because [TRIVIAL]

@intelliot intelliot merged commit 40ebbec into XRPLF:develop Oct 4, 2023
15 checks passed
florent-uzio pushed a commit to florent-uzio/rippled that referenced this pull request Oct 6, 2023
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants