Check triggers cmake error unnecessarily #4150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
For Visual Studio 2017 and prior, the default wasn't x64 so generator platform couldn't be left blank. |
sounds good to me! |
ximinez
approved these changes
Apr 28, 2022
Thanks, can you approve the PR @legleux ? |
legleux
approved these changes
Apr 28, 2022
greg7mdp
added
the
Passed
Builds/CMake/RippledSanity.cmake
Outdated
Comment on lines
75
to
78
| if ("${CMAKE_GENERATOR}" MATCHES "Visual Studio" AND | ||
| NOT ("${CMAKE_GENERATOR}" MATCHES .*Win64.*)) | ||
| ("${CMAKE_GENERATOR_PLATFORM}" MATCHES .*Win32.*)) | ||
| message (FATAL_ERROR | ||
| "Visual Studio 32-bit build is not supported. Use -G\"${CMAKE_GENERATOR} Win64\"") |
There was a problem hiding this comment.
How about this instead?
if (MSVC AND CMAKE_GENERATOR_PLATFORM STREQUAL "Win32")
message (FATAL_ERROR
"Visual Studio 32-bit build is not supported. Use -A x64")There was a problem hiding this comment.
Yes, looks better. I'll do a sanity check and update it.
There was a problem hiding this comment.
@thejohnfreeman I did the change, removing the -A x64 as it does not seem to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect error for cmake execution on windows when platform unspecified or x64
Context of Change
When using cmake-gui to generate solution files on windows, the default platform is stated to be x64, so it is natural to leave the field unfilled, but even among the proposed choices, Win64 is nowhere to be found, we see only x64.
So whether we leave the field blank, or select x64 in the dropdown, cmake generation fails because it checks for the presence of
Win64.This change makes the generation of solution files more user friendly on windows, by not causing an error unless we find
Win32.Type of Change