ASAN stack-use-after-scope in soci::use with rvalues (Version: [1.12.0-rc1])

[StefanVK]

Issue Description

We have stack-use-after-scope bugs since we're using ravlues with soci::use

Steps to Reproduce

Build rippled with -Dsan=address, start a fresh Ledger server and trigger e.g. peer_reservations_add from a second instance. You may need to use a rather recent compiler for asan to catch most stack-use-after-scope errors.

mkdir build
cd build
conan install .. --output-folder . --build missing --settings build_type=Debug -o reporting=True
cmake -DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake -DCMAKE_BUILD_TYPE=Debug -Dsan=address -Dreporting=ON -DCMAKE_C_COMPILER=clang-15 -DCMAKE_CXX_COMPILER=clang++-15 -DCMAKE_EXPORT_COMPILE_COMMANDS=ON ..
cmake --build . -j 12
./rippled-reporting --start -a
./rippled-reporting peer_reservations_add n9Mxf6qD4J55XeLSCEpqaePW4GjoCR5U1ZeGZGJUCNe3bQa4yQbG 

Actual Result

ASAN detects stack use after scope which at least for insertPeerReservation and deletePeerReservation means we are accessing a std::string which already has been deleted. In updateLedgerDBs this may be more of an academic issue. But for the peer reservations we could actually get the nodeId overwritten by a different thread while we're reading it since the actual string content is on the heap.

Environment

My Dockerfile:

FROM ubuntu:22.04
RUN apt-get update
RUN apt-get -y upgrade
RUN apt-get -y install git scons ninja-build clang
RUN DEBIAN_FRONTEND=noninteractive apt-get -yq install pkg-config
RUN apt-get -y install protobuf-compiler libprotobuf-dev libssl-dev libboost-all-dev python-is-python3 cmake clang-15 clangd-15 g++ pip dotnet-runtime-6.0 curl clang-format-11
RUN rm /usr/bin/clang && rm /usr/bin/clang++ && ln -s /usr/bin/clangd-15 /usr/bin/clangd && ln -s /usr/bin/clang-15 /usr/bin/clang && ln -s /usr/bin/clang++-15 /usr/bin/clang++ && ln -s /usr/bin/clang-format-11 /usr/bin/clang-format
ENV CC=clang  
ENV CXX=clang++
RUN pip install conan==1.60.2 && conan profile new default --detect && conan profile update settings.compiler.cppstd=20 default && conan profile update settings.compiler.libcxx=libstdc++11 default

git rev-parse HEAD
300b7e078a4bc511f30b74509d416e5081ec3650

Supporting Files

See also https://github.com/SOCI/soci/blob/master/docs/binding.md#object-lifetime-and-immutability and SOCI/soci#1070

server log with ASAN error
My rippled.cfg equals rippled-example.cfg and validators.txt equals validators-example.txt