Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Improve instructions for finding and applying the patch generated by failed Github Actions (Version: 1.8.1) #4020

Closed
ximinez opened this issue Dec 8, 2021 · 2 comments · Fixed by #4521
Closed

CI: Improve instructions for finding and applying the patch generated by failed Github Actions (Version: 1.8.1) #4020

ximinez opened this issue Dec 8, 2021 · 2 comments · Fixed by #4521
Labels
CI Continuous Integration Functionality Documentation README changes, code comments, etc. Good First Issue Great issue for a new contributor

Comments

@ximinez
Copy link
Collaborator

ximinez commented Dec 8, 2021

Issue Description

The instructions provided on failed jobs (example) don't clearly explain where to find the generated patch file. This can be a problem for anyone who is not familiar with how Github Actions pages are organized.

The general idea is:

From the details page, click on "Summary", then scroll down to the "Artifacts" section. There's a clang-format.patch/levelization.patch file there. Download it into your repo then run git apply [patchfile]. Commit and push.
@ximinez ximinez added CI Continuous Integration Functionality Documentation README changes, code comments, etc. labels Dec 8, 2021
@thejohnfreeman thejohnfreeman added the Good First Issue Great issue for a new contributor label Dec 13, 2021
@abuharish02
Copy link

Screenshot (25)
Hey, "clang-format.patch" file is not available. Kindly provide me.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Core Ledger Mar 14, 2023
@intelliot
Copy link
Collaborator

To download the patch file:

  1. Next to clang-format / check (pull_request) Failing after #s -> click Details
  2. Left menu -> click Summary
  3. Near bottom right under Artifacts -> click clang-format.patch

intelliot added a commit that referenced this issue May 11, 2023
@intelliot
docs: explain how to find a clang-format patch generated by CI
fb70239 
Fix #4020
@intelliot intelliot mentioned this issue May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Functionality Documentation README changes, code comments, etc. Good First Issue Great issue for a new contributor
Projects
Core Ledger
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: explain how to find a clang-format patch generated by CI XRPLF/rippled
5 participants
@intelliot @thejohnfreeman @ximinez @abuharish02 and others