Store closeTime in LedgerFill

XRPLF · Oct 26, 2023 · 4e92ee4 · 4e92ee4
1 parent 1115cef
commit 4e92ee4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/ripple/app/ledger/LedgerToJson.h b/src/ripple/app/ledger/LedgerToJson.h
@@ -21,8 +21,10 @@
 #define RIPPLE_APP_LEDGER_LEDGERTOJSON_H_INCLUDED
 
 #include <ripple/app/ledger/Ledger.h>
+#include <ripple/app/ledger/LedgerMaster.h>
 #include <ripple/app/misc/TxQ.h>
 #include <ripple/basics/StringUtilities.h>
+#include <ripple/basics/chrono.h>
 #include <ripple/json/Object.h>
 #include <ripple/protocol/STTx.h>
 #include <ripple/protocol/jss.h>
@@ -41,6 +43,8 @@ struct LedgerFill
         LedgerEntryType t = ltANY)
         : ledger(l), options(o), txQueue(std::move(q)), type(t), context(ctx)
     {
+        if (context)
+            closeTime = context->ledgerMaster.getCloseTimeBySeq(ledger.seq());
     }
 
     enum Options {
@@ -58,6 +62,7 @@ struct LedgerFill
     std::vector<TxQ::TxDetails> txQueue;
     LedgerEntryType type;
     RPC::Context* context;
+    std::optional<NetClock::time_point> closeTime;
 };
 
 /** Given a Ledger and options, fill a Json::Object or Json::Value with a

diff --git a/src/ripple/app/ledger/impl/LedgerToJson.cpp b/src/ripple/app/ledger/impl/LedgerToJson.cpp
@@ -162,10 +162,9 @@ fillJsonTx(
             {
                 txJson[jss::ledger_index] = to_string(fill.ledger.seq());
                 txJson[jss::ledger_hash] = to_string(fill.ledger.info().hash);
-                if (auto close_time =
-                        fill.context->ledgerMaster.getCloseTimeBySeq(
-                            fill.ledger.seq()))
-                    txJson[jss::close_time_iso] = to_string_iso(*close_time);
+                if (fill.closeTime)
+                    txJson[jss::close_time_iso] =
+                        to_string_iso(*fill.closeTime);
             }
         }
         else