Skip to content

Commit

Permalink
Review comment fixes.
Browse files Browse the repository at this point in the history
  • Loading branch information
mtrippled authored Oct 26, 2023
1 parent 77052d2 commit 3f727fb
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/ripple/consensus/Consensus.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@ checkConsensusReached(
std::size_t minConsensusPct,
bool reachedMax)
{
// If we are alone for too long, we have a consensus
// If we are alone for too long, we have consensus.
// Delaying consensus like this avoids a circumstance where a peer
// gets ahead of proposers insofar as it has not received any proposals.
// This could happen if there's a slowdown in receiving proposals. Reaching
// consensus prematurely in this way means that the peer with desync.
// consensus prematurely in this way means that the peer will likely desync.
// The check for reachedMax should allow plenty of time for proposals to
// arrive, and there should be no downside. If a peer is truly not
// receiving any proposals, then there should be no hurry. There's
Expand Down Expand Up @@ -143,7 +143,7 @@ checkConsensus(
<< previousAgreeTime.count()
<< " proposing? " << proposing
<< " minimum duration to reach consensus: "
<< parms.ledgerMIN_CONSENSUS.count() << "ms"
<< parms.ledgerMIN_CONSENSUS.count() << "s"
<< " max consensus time " << parms.ledgerMAX_CONSENSUS.count() << 's'
<< " minimum consensus percentage: " << parms.minCONSENSUS_PCT;

Expand Down

0 comments on commit 3f727fb

Please sign in to comment.