fix: AccountNFT with invalid marker

[PeterChen13579]

Fixes #1497
Mimics the behavior of the fix on Rippled side

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.87%. Comparing base (2bd7ac3) to head (aadba7c).
Report is 15 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1589      +/-   ##
===========================================
+ Coverage    69.54%   69.87%   +0.33%     
===========================================
  Files          254      260       +6     
  Lines         9892     9921      +29     
  Branches      5463     5470       +7     
===========================================
+ Hits          6879     6932      +53     
+ Misses        1595     1589       -6     
+ Partials      1418     1400      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[godexsoft]

Nice, just a few nits 👍

[cindyyan317]

Good stuff 👍

I think the marker is different in Clio, comparing with rippled. So rippled's approach might not work on Clio.
Also please check the document https://xrpl.org/docs/references/http-websocket-apis/public-api-methods/account-methods/account_nfts#account_nfts, I think Clio's limit is also different.

[shawnxie999]

@cindyyan317 rippled can directly fetch a page based on the NFTokenID marker. But clio can't do this, it has to traverse from the last page. So I assume that's why the marker is the ID of the page itself. I think we can still try to return a NFTokenID as a marker, but it would require clio to traverse from the last token page everytime a marker is provided, which would make the API less efficient

[cindyyan317]

@cindyyan317 rippled can directly fetch a page based on the NFTokenID marker. But clio can't do this, it has to traverse from the last page. So I assume that's why the marker is the ID of the page itself. I think we can still try to return a NFTokenID as a marker, but it would require clio to traverse from the last token page everytime a marker is provided, which would make the API less efficient

@shawnxie999 Thanks for the suggestion. According to the doc , the marker should be page id. We will flag this mismatch to rippled and discuss the correct fix.

For this PR, I think we don't mimic rippled. The marker is considered valid if it is a valid page object of account .

[cindyyan317]

LGTM

[godexsoft]

👍