Update XoopsFormRendererBootstrap5.php #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move 'MAX_FILE_SIZE' go forward
|
Should it be also changed for XoopsFormRendererBootstrap4.php ? Also, can you give a background for this change? The order of hidden input elements is generally not significant in HTML forms, and Bootstrap 5 doesn't impose any additional constraints or behaviors that would make the order significant in this case. |
mambax7
requested review from
alain01,
geekwright,
ggoffy,
liomj and
GregMage
geekwright
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Technically, CHCCD is correct.
See: https://www.php.net/manual/en/features.file-upload.post-method.php
The MAX_FILE_SIZE hidden field (measured in bytes) must precede the file input field, ...
Changes similar to this would be needed in the other XoosFormRenderer* classes
I am a bit surprised by this being an issue, but it is documented in PHP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move 'MAX_FILE_SIZE' go forward