Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

689: translations not generated for choice list used with search() [tests] #693

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

lindsay-stevens
Copy link
Contributor

Follow up to #690 to finish the test cases.

Why is this the best possible solution? Were any other approaches considered?

Covers use cases in relation to choice / translation behaviour per the XLSForm docs. I found the numbered list there a bit abstract, so for reference this docs page from SurveyCTO has good illustrations of the advanced usages.

What are the regression risks?

None, it's just tests.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Not directly, but I noticed a dead link on the XLSForms docs page. Not sure if the file is gone or it's a permissions issue:

For an example, see the advanced search-and-select sample form here.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run nosetests and verified all tests pass
  • run black pyxform tests to format code
  • verified that any code or assets from external sources are properly credited in comments

Copy link
Contributor

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@lognaturel lognaturel merged commit 0f6b4a5 into XLSForm:master Jan 29, 2024
10 checks passed
@lindsay-stevens lindsay-stevens deleted the pyxform-689 branch February 1, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants