feat: DB queue, error messaging and document upload error codes #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't needed in the rest of the class
…ues with talking to mysql
…rl fields to an empty string before running table modification
…nd dependency resolutions (#1154) * feat: add more feeOptions - prevent auto submission (#1141) * add more feeOptions * fix schema * change tests for new feeOptions * custom error message * renaming to maxAttempts * Removed extra space --------- Co-authored-by: Luke Zigler <[email protected]> * Added README for submitter * Added docs for enabling the queue service from the runner side * Updated dependencies * More dependency updates * Updated babel dependencies across project * Updated babel-jest packages * Added resolution for babel core * Updated lockfile * Added resolution for babel traverse * Allowed postcss GHSA to avoid upgrading webpack * Fixed md table formatting * fix: change customPayErrorMessage type to string --------- Co-authored-by: Luke Zigler <[email protected]>
jenbutongit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please also include any acceptance criteria if you have any.
DB based queue and submission process
Architecture decision record
documentation / how to use this feature
Updates to error messages
We've updated error messaging to be in line with GOV.UK design system guidance.See more detail in the pull request #1136
Updates to document upload api
You may now return error codes (alongside status codes) from your document upload API. The form runner will accept the following codes from your document upload API to show tailored errors to the user:
These codes should be sent in the response payload as a string.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.
Checklist: