Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom labels and badge styles. Add License. Upgrade and Remove unused dependencies. #166

Merged
merged 29 commits into from
Sep 9, 2022

Conversation

elliotwutingfeng
Copy link
Contributor

Live Demo

Deployed on render.com free tier.

This is an example label

This is another example label

Proposed Changes

  • Support custom labels and badge styles, similar to what shields.io offers.
    • Made possible by replacing badge crate with rsbadges crate (BSD 3-Clause License).
    • The new crate supports badge logos, but I'd consider it out of scope for now.
  • Add Apache and MIT Licenses. Addresses Add libre license #103
  • Add some files to gitignore based on standard Rust gitignore template.
  • Upgrade and Remove unused dependencies.
    • GitHub actions and earthly versions bumped to latest
    • Rust version upgraded to 2021
    • Cargo dependencies bumped.
    • Unused Cargo dependencies removed to reduce compilation time (sidenote: long compiliation time was causing builds to fail on render.com free tier, this may not be an issue on other hosting platforms)

Known issues

Getting 403 errors with ghcr.io

In deploy.yml, sometimes the default ${{ secrets.GITHUB_TOKEN }} may not work well with ghcr.io.

A workaround would be to create and use a GitHub Personal Access Token with write:packages access enabled, no expiry date, and add it to this repository (e.g. ${{ secrets.PERSONAL_ACCESS_TOKEN }}).

@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 0821a56 into XAMPPRocky:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants