-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lingua franca language #993
Conversation
| "{{key}}" => Some({{key}}), | ||
{% endfor %} | ||
unknown => { | ||
warn!("Unknown language name: {}", unknown); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have a warn!
here, because people use it as a library, and they may not want to have it warn when getting None
can be expected behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks! I'll change that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually all other such methods like from_file_extension
use a warn!
call, so maybe this change should be part of another PR?
Thank you for your PR! I'll try to review this more throughly in the future 🙂 |
Thank you for your PR, and congrats on your first contribution! 🎉 |
This adds support for the Lingua Franca language (LF). LF is a coordination language that embeds fragments of another language (eg Rust, C, Python). For that reason tokei's embedded language feature is very valuable. Here's a sample output when run on this repo: