PHP 8 Support #25
Merged
PHP 8 Support #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome thank you! It was already on my list but it's great to see you picked this up already 👍 |
|
You're welcome. Are you planning on releasing this soon? |
|
Yeah within the hour, just need to add a few more workflows and such from other repo's I've been working on upgrading |
|
Great, thanks. Good luck! |
|
@Nielsvanpach Done: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be great to see this package support PHP 8!
You can see the tests passed on my fork: https://github.com/Nielsvanpach/reactphp-child-process-promise/actions/runs/400933361