Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connected textures #45

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

iijj22gg
Copy link

This adds a basic built-in resource pack that adds ctm

Currently, the ctm is state based and only includes the normal glass, with ctm added for all relevant partial textures. This was easy to do as a proof-of-concept.

This may require Continuity for everything other than full faces, since I don't think Optifine properly supports namespaces.

Also, I have never dealt with a mod's source before, so I have no idea how this works. I just put the resource pack in the same place that Continuity puts their built-in packs, and I haven't yet looked into how to build it.

Stuff to do:

  1. Add ctm to stained and tinted glass. Requires new textures.
  2. Test with Optifine
  3. Add translations to pack description
  4. Connect textures between specific blockstates. Requires many new textures and many properties files.

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2024

CLA assistant check
All committers have signed the CLA.

@Alexander01998 Alexander01998 linked an issue Nov 30, 2024 that may be closed by this pull request
@Alexander01998 Alexander01998 added the enhancement New feature or request label Nov 30, 2024
@iijj22gg
Copy link
Author

iijj22gg commented Dec 1, 2024

So... extracting the jar and putting the resource pack in the same place as I see built-in resource packs in other mods like Continuity does not work, so I assume it needs to be declared somewhere in the mod.
I tried building the mod to see if it happens automatically, but I can only get it to build for verision 1.21.3, and issue #46 exists

@Alexander01998
Copy link
Member

Hey, first off thanks for the PR! I'll take a closer look soon but am kind of busy preparing for 1.21.4 right now.

@Alexander01998 Alexander01998 added the status:never-stale Prevents stalebot from marking this item as stale. label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status:never-stale Prevents stalebot from marking this item as stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optifine and Continuity both support CTM for slabs and stairs
3 participants