Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optifine and Continuity both support CTM for slabs and stairs #43

Open
iijj22gg opened this issue Nov 26, 2024 · 2 comments · May be fixed by #45
Open

Optifine and Continuity both support CTM for slabs and stairs #43

iijj22gg opened this issue Nov 26, 2024 · 2 comments · May be fixed by #45
Labels
enhancement New feature or request status:never-stale Prevents stalebot from marking this item as stale.

Comments

@iijj22gg
Copy link

iijj22gg commented Nov 26, 2024 •
edited
Loading

So uhhh... I'm not sure where you got the idea that there was no CTM support for these...

Just put this on top of continuity's CTM, and boom, basic slab CTM.

glass_slab.properties

matchBlocks=mo_glass:glass_slab:type=bottom,top
tiles=0-46
connect=block
faces=top, bottom
resourceCondition=textures/block/glass.png

image

There's a little bit of jank with double slabs, but CTM does work with both slabs and stairs. If you don't believe me, I will make a PR to prove it.
Stairs will require many, many properties files...
@Alexander01998
Copy link
Member

Alexander01998 commented Nov 26, 2024 •
edited
Loading

Great to hear! Yes, a PR for this would be very welcome. 👍

(Even if it's just a proof of concept for the normal slabs and stairs. I can write a script to generate the remaining config files from there.)

@iijj22gg
Copy link
Author

Alright, I'll get started on it. I will submit a PR adding an built-in resource pack that will enable it.
It's going to take a bit to get CTM working correctly on the stairs, because I need to get the orientations to connect right.

@Alexander01998 Alexander01998 added the enhancement New feature or request label Nov 29, 2024
@Alexander01998 Alexander01998 linked a pull request Nov 30, 2024 that will close this issue
Add connected textures #45
Draft
@Alexander01998 Alexander01998 added the status:never-stale Prevents stalebot from marking this item as stale. label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request status:never-stale Prevents stalebot from marking this item as stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add connected textures iijj22gg/Mo-Glass-CTM
2 participants
@Alexander01998 @iijj22gg