Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update namespace in test classes to match the actual location #1

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Update namespace in test classes to match the actual location #1

merged 1 commit into from
Aug 8, 2018

Conversation

hordijk
Copy link

@hordijk hordijk commented Jul 31, 2018

  • Moved classes to a folder matching the namespace used.
  • Fixed namespace for NameSpaceHandlerTest to match the location the file is located

Copy link
Member

@mikaelcom mikaelcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the namespace is originally wrong within the classes your modified.
It should be WsdlToPhp\DomHandler\Tests for all the classes. Then there would be no need to move the classes to another folder.
Just as the tests/NameSpaceHandlerTest.php would be good.
Any opposite opinion?

@mikaelcom
Copy link
Member

By the way, thanks for your work!

@hordijk
Copy link
Author

hordijk commented Aug 1, 2018

I agree, the classes under test are in the WsdlToPhp\DomHandler namespace. The original namespace used in the test classes is wrong. Updated the branch and squash commits in the branch.

@hordijk hordijk changed the title Aligned folders with the namespace used in the test classes Update namespace in test classes to match the actual location Aug 1, 2018
@mikaelcom mikaelcom merged commit 2f9b352 into WsdlToPhp:develop Aug 8, 2018
@hordijk hordijk deleted the AddDirectoryForNamespaceOfTestClasses branch August 21, 2018 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants