-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fixed hide on startup problem #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| { | ||
| mainVM.MainWindowVisibility = Visibility.Visible; | ||
| } | ||
| mainVM.MainWindowVisibility = _settings.HideOnStartup ? Visibility.Hidden : Visibility.Visible; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this fixed hide on startup problem?
I didn't find any difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I put a breakpoint on if (!_settings.HideOnStartup) mainVM.MainWindowVisibility was already Visibility.Visible by default, which results in still showing the Wox window after startup when "Hide Wox on startup" is selected. I experienced this on two pc's both running Windows 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
make sense
will merge after I off from work
|
Hey @happlebao |
1. Fixed HideOnStartup 2. Fixed tray icon not showing up and hiding properly
* Fixed HideOnStartup * Fixed tray icon not showing up and hiding properly
|
done. with a bit of rebase |
|
I think I also know why it failed before. This is my metadata on Windows 10 |
|
I don't know, but it doesn't matter. initialize everything explicitly is always the best option. |
* Fixed HideOnStartup * Fixed tray icon not showing up and hiding properly
Fixes bug which happens at least on Windows 10 where Wox is not hidden on startup when "Hide Wox on startup" is selected. It broke the tray icon so I fixed that too.