Skip to content

Conversation

@tinymins
Copy link

Add 'Pause Command Prompt after command execution' option to shell plugin, and set default to false.

@tinymins
Copy link
Author

image

@tinymins
Copy link
Author

Hello, I just rebased my branch from upstream so that some of the admin can merge it easily.

Most of the time when we press WIN+R, we just want to start something likes > msinfo32. Thus, we do not need to keep the console, and it's very annoying that we need to close the console manually for every single time.

@lances101
Copy link
Member

lances101 commented Jan 4, 2018

I will merge this into dev tonight. Thank you for your PR. Next time please PR from and into dev.

lances101 added a commit that referenced this pull request Jan 4, 2018
@lances101
Copy link
Member

lances101 commented Jan 4, 2018

Merged into dev as of 35368b6. Thank you for your contribution!

Please PR from dev (or a branch with dev as base) and against dev next time so that the PR process can be done here on Github without manual merges.


First and foremost, my apologies. I was a little hasty and should've asked if you would like to make a new PR against dev first as in the way I did it thecommit history only has a reference to this PR without your direct commit. Sorry.

Changing the branch of the PR here on Github adds about 1000+ commits to merge from the master branch to dev (these, potentially, could be squashed so that they don't appear).

If you'd like to, please do a new PR (your dev to Wox dev), I will reverse commit my own merge and accept your PR so that it's reflected in the commit history.

@lances101 lances101 changed the base branch from master to dev January 4, 2018 17:29
@lances101 lances101 changed the base branch from dev to master January 4, 2018 17:29
@tinymins
Copy link
Author

tinymins commented Jan 8, 2018

Give me a second, and I'll do a new PR now, thanks. 😃

@jhdxr
Copy link
Member

jhdxr commented Jan 8, 2018

@lances101 next time you may try https://github.com/Wox-launcher/Wox/pull/1490.patch , git apply the patch, it will keep the author info, and you will be shown in the attribute committer.

lances101 added a commit that referenced this pull request Jan 13, 2018
@lances101 lances101 closed this Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants