Skip to content

Remove WebRequest usage #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Remove WebRequest usage #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ed4b7f
Remove WebRequest usage
twsouthwick Feb 21, 2025
9ceba1d
Merge branch 'staging' into remove-webrequest
Carifio24 Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/WWT.Imaging/WWT.Imaging.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<NoWarn>$(NoWarn);SYSLIB0014</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
10 changes: 5 additions & 5 deletions src/WWT.Providers/OtherProviders/IssTleProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
using System;
using System.Net;
using System.Net.Http;
using System.Threading;
using System.Threading.Tasks;

namespace WWT.Providers
{
[RequestEndpoint("/wwtweb/isstle.aspx")]
public class IsstleProvider : RequestProvider
public class IsstleProvider(IHttpClientFactory factory) : RequestProvider
{
public override string ContentType => ContentTypes.Text;

Expand All @@ -30,10 +30,10 @@ public override async Task RunAsync(IWwtContext context, CancellationToken token

if (String.IsNullOrEmpty(reply) || ts.TotalDays > .5 || context.Request.Params["refresh"] != null)
{
using (WebClient wc = new WebClient())
using (var client = factory.CreateClient())
{
string data = wc.DownloadString(theUrl);
string[] lines = data.Split(new char[] { '\n', '\r' });
string data = await client.GetStringAsync(theUrl, token);
string[] lines = data.Split(['\n', '\r']);

string line1 = "";
string line2 = "";
Expand Down
1 change: 0 additions & 1 deletion src/WWT.Providers/WWT.Providers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<Nullable>disable</Nullable>
<NoWarn>$(NoWarn);SYSLIB0014</NoWarn>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>

Expand Down