-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MT generated main languages for testing #1952
base: master
Are you sure you want to change the base?
Added MT generated main languages for testing #1952
Conversation
I'm going to go through the TODO: localize today, don't approve this yet |
This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
# Conflicts: # client/lib/main.dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clementmouchet - this is great, let's get this landed ASAP to try it out
You have two failing checks that are visible in the PR "conversation" view or the "checks" view:
https://github.com/WorldHealthOrganization/app/pull/1952/checks
Still need to clean up a few more instances of // TODO: localize
:
2 instances - client/lib/pages/main_pages/learn_page.dart
2 instances - client/lib/pages/settings_page.dart
1 instance - client/lib/pages/symptom_checker/question_pages/next_button.dart
1 instance - client/lib/pages/onboarding/country_list_page.dart
1 instance - client/lib/pages/symptom_checker/question_pages/short_list_question_view.dart
@clementmouchet - you need to run the following command and I think it will fix up the last two issues meaning that you can pass everything:
For future reference, you can click on the links to see what's happening: |
This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Screenshots
MT generated files for testing
How did you test the change?
curl
to a dev App Engine server