Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MT generated main languages for testing #1952

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

clementmouchet
Copy link
Contributor

Screenshots

MT generated files for testing

How did you test the change?

  • iOS Simulator
  • iOS Device
  • Android Simulator
  • Android Device
  • curl to a dev App Engine server
  • other, please describe

@clementmouchet
Copy link
Contributor Author

I'm going to go through the TODO: localize today, don't approve this yet

@stale
Copy link

stale bot commented Mar 4, 2021

This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the resolved:stale No recent activity on the issue or PR label Mar 4, 2021
@stale stale bot removed the resolved:stale No recent activity on the issue or PR label Apr 6, 2021
@stale
Copy link

stale bot commented Apr 14, 2021

This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the resolved:stale No recent activity on the issue or PR label Apr 14, 2021
@stale stale bot removed the resolved:stale No recent activity on the issue or PR label Apr 18, 2021
# Conflicts:
#	client/lib/main.dart
Copy link
Collaborator

@brunobowden brunobowden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clementmouchet - this is great, let's get this landed ASAP to try it out

You have two failing checks that are visible in the PR "conversation" view or the "checks" view:
https://github.com/WorldHealthOrganization/app/pull/1952/checks

Still need to clean up a few more instances of // TODO: localize:
2 instances - client/lib/pages/main_pages/learn_page.dart
2 instances - client/lib/pages/settings_page.dart
1 instance - client/lib/pages/symptom_checker/question_pages/next_button.dart
1 instance - client/lib/pages/onboarding/country_list_page.dart
1 instance - client/lib/pages/symptom_checker/question_pages/short_list_question_view.dart

@brunobowden
Copy link
Collaborator

@clementmouchet - you need to run the following command and I think it will fix up the last two issues meaning that you can pass everything:

flutter format lib/**

For future reference, you can click on the links to see what's happening:
https://github.com/WorldHealthOrganization/app/pull/1952/checks?check_run_id=2379191247

@stale
Copy link

stale bot commented Apr 29, 2021

This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the resolved:stale No recent activity on the issue or PR label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolved:stale No recent activity on the issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants