Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation on bullet points Issue #1912

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Indentation on bullet points Issue #1912

wants to merge 3 commits into from

Conversation

champ96k
Copy link
Contributor

@champ96k champ96k commented Jan 6, 2021

this issue solve suing flutter_widget_from_html

Fixes #1859

System

  • OS: Android 9.0
  • Device: Redmi 8A

Screenshot:

Screenshot

Checklist:

@champ96k champ96k changed the title solve Indentation on bullet points #1859 Issue solve Indentation on bullet points Issue Jan 6, 2021
@champ96k
Copy link
Contributor Author

champ96k commented Jan 6, 2021

Created new PR #1912

Copy link
Contributor Author

@champ96k champ96k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self code review done

@brunobowden
Copy link
Collaborator

@champ96k - this is a creative use of the flutter_widget_from_html but the very thing I was concerned about is in the commit. There's a massive increase in the number of libraries, all of which need to go through some kind of security vetting and that's beyond what the volunteer team can manage right now. For example, I'm suspicious about why it pulls in a dependency like wakelock... which the WHO app doesn't need for any reason. We don't have the engineering capacity right now to consider such an extensive change. Adding these dependencies might well be a good move for other benefits, e.g. embedding videos and other functionality.... but this would be a large amount of work to just fix the indentation and the other benefits aren't clear at the moment. It's just not worth it at this point. See the earlier comment that was trying to speak to this: #1859 (comment)

P.S. You should include in the description "Fixes #1859" to have GitHub automatically close the issue if the PR was accepted. At this point, we won't be able to do that.

@theswerd
Copy link
Contributor

theswerd commented Jan 7, 2021

What is the benefit to using flutter_widget_from_html over flutter_html?

From what I have seen flutter_html is more generally used.

@theswerd
Copy link
Contributor

theswerd commented Jan 7, 2021

This also adds the open_iconic_flutter full icon pack.

@champ96k champ96k changed the title solve Indentation on bullet points Issue Fixes #1859 Indentation on bullet points Issue Jan 7, 2021
@champ96k
Copy link
Contributor Author

champ96k commented Jan 7, 2021

What is the benefit to using flutter_widget_from_html over flutter_html?

From what I have seen flutter_html is more generally used.

flutter_widget_from_html is a extension of flutter_html package with include some extra fetures

@brunobowden brunobowden changed the title Fixes #1859 Indentation on bullet points Issue Indentation on bullet points Issue Jan 10, 2021
@stale
Copy link

stale bot commented Jan 17, 2021

This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the resolved:stale No recent activity on the issue or PR label Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolved:stale No recent activity on the issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation on bullet points
3 participants