Firebase App Distribution with Fastlane #1293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicfaace
requested review from
britannio,
brunobowden,
crazybob,
patniemeyer,
SamMousa and
theswerd
as code owners
…flict with CI format checks
|
We'll address this after v1.0. |
|
This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This item has been automatically closed as stale. |
advayDev1
added
the
deployment
6 tasks
|
@epicfaace - now we've got approval for releasing the app. @joshdholtz - please review or let us know how else we should go about this. |
advayDev1
removed request for
crazybob,
SamMousa,
patniemeyer,
hspinks and
advayDev1
brunobowden
changed the title
|
@brunobowden I don't think this is relevant anymore -- closing it, but let me know otherwise. |
|
@epicfaace - it is something we should do at some point. Is it worth accepting the PR just so that it can stick around in the tree for when we pick it up later on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
Setup fastlane for firebase app distribution (fixes #1044). Instructions for deploying this are in release/manual-build.md.
I've added one lane,
distribute(for who-myhealth-production). When actually deploying to firebase app distribution, we should runbundle exec fastlane distributeso that the app is deployed to who-myhealth-production.In order to test the fastlane integration, I replaced the app id in Fastfile with
1:1057717871229:android:4fbe832a3de230450dc714(which is the app id in who-myhealth-staging) and then deployed to who-myhealth-staging.dependencies
Also added a Gemfile.lock -- this is needed to pin down dependencies used by fastlane (such as firebase_app_distribution).
The new dependency,
fastlane-plugin-firebase_app_distribution, is also maintained by the fastlane team.