RTL support and Arabic Translations, closes #978 #1067
Conversation
…t in the RTL languages, also get more margin space to right, part of issue WorldHealthOrganization#978
nLoops
requested review from
advayDev1,
brunobowden,
crazybob,
hspinks,
patniemeyer,
SamMousa and
theswerd
as code owners
hspinks
added
client
|
from the homepage screenshot - shouldn't the alignment be to the right? also there's an ampersand (also on the questions page) |
| ); | ||
| Widget build(BuildContext context) => Transform.rotate( | ||
| // back arrow need to point right in the RTL languages. | ||
| angle: Constants.isDirectionRTL(context) ? 180 * pi/180 : 0, |
There was a problem hiding this comment.
Ideally we would mirror rather than rotate.
There was a problem hiding this comment.
Yup, in this case, we need another SVG data for the right arrow.
There was a problem hiding this comment.
You can rotate around the Y axis using Transform(transform :Matrix4.rotationY(180)...)
see https://stackoverflow.com/questions/58047009/flutter-how-to-flip-an-icon-to-get-mirror-effect
There was a problem hiding this comment.
I will give it a try, but I think it's the same behavior.
advayDev1
changed the title
|
This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This item has been automatically closed as stale. |
|
@nLoops - thanks for your work on this before. Now that the app is launched, it would be great to get your RTL work landed. My hope is that there's isn't too much change to resolve the merge conflicts. We're about to kick off translation, so RTL is clearly important for that. I'm sure there's some other work that will be needed too on localization, so it would be very helpful to have your help on that. Please connect with me on the Slack #localization channel. Email me at [email protected] if you need an invite. |
|
@nLoops - FYI, the strings have probably changed quite a bit since you do the original translation.... but we'll figure that out too. |
|
This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please follow this checklist. Please check each appropriate box (put an 'x' or check it after creating the PR).
After all boxes above are checked, request and receive an Approved review from any team member knowledgable in the area (TODO team member list). Once approved, the team member will assign your review to a Committer or use the
needs-mergelabel.What does this PR accomplish?
Added the Arabic translation ARB file, also improve layouts behavior with RTL languages by making the appbar back-arrow points to the right and adding some margin space to the right.
issue #978
PS. there're some parts of texts not covered by the ARB files, and it will be provided by LINGO24.
Did you add any dependencies?
No.
How did you test the change?
Android device screenshots