Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation on bullet points #1859

Open
2 tasks done
msaini888 opened this issue Dec 20, 2020 · 6 comments · May be fixed by #1912
Open
2 tasks done

Indentation on bullet points #1859

msaini888 opened this issue Dec 20, 2020 · 6 comments · May be fixed by #1912
Assignees
Labels
client-ui Client user interface P2 "Nice to have" - shipping next version without this will not have a major impact source:qa From QA team

Comments

@msaini888
Copy link

msaini888 commented Dec 20, 2020

Steps to reproduce the behavior:

  1. Launch the app
  2. Complete Onboarding journey.
  3. Tap on Learn tab in the footer.
  4. Tap on Questions & Answers
  5. Expand the section which says "What should I do if I have been exposed to someone who has COVID-19?"

Expected Behavior
Text Alignment should be proper

Actual Behavior
Text Alignment is not proper.

System

  • Device: Huawei Honor 7c
  • OS: Android 8.0
  • App Version: version 1.0.0-staging(281)

Screenshots

Screenshot_20201220-191403

Checklist:

@msaini888 msaini888 added needs:triage New issue that needs triage source:public Issues created by the public client-ui Client user interface P2 "Nice to have" - shipping next version without this will not have a major impact source:qa From QA team and removed needs:triage New issue that needs triage source:public Issues created by the public labels Dec 20, 2020
@brunobowden brunobowden changed the title Text Alignment on Q&A Screen needs to get adjusted Indentation on bullet points Dec 20, 2020
@champ96k
Copy link
Contributor

@Mohit020888 and @brunobowden can please assign me this issue I would love to work on this issue :)

Thanks

@msaini888
Copy link
Author

@champ96k - thanks for volunteering to fix this one as well !
I have assigned it to you 👍

@brunobowden
Copy link
Collaborator

@Mohit020888 @champ96k - it's going to be important that this looks good on very small screens. So please post a screenshot as part of any PR. Perhaps fixing the indentation will look better.... but also reduce the margin to the left of the bullet points as well.

My concern in part is that "unordered lists" or <ul> exist throughout the app content. So this should be a general fix for everything and not just this single page. See search results for all the content examples:
https://github.com/WorldHealthOrganization/app/search?q=%3Cul%3E

@champ96k
Copy link
Contributor

champ96k commented Jan 2, 2021

@brunobowden, @Mohit020888 Thanks for the detailed explanation, I definitely take care of all things

@brunobowden
Copy link
Collaborator

@champ96k - main thing is that if the change starts looking too complex, then I'd question whether it's worth doing anything at all. It may be that the additional complexity is brittle and hard to maintain, which doesn't make sense for the product. See what you experiment with and feel free to share some preliminary before it takes up too much of your time.

@champ96k
Copy link
Contributor

champ96k commented Jan 6, 2021

@brunobowden, @Mohit020888, The current flutter html is still not supported for Indentation on bullet points, as someone created PR on flutter html Add support for inline styles to new parser but still flutter html is not supported for html unordered list Indentation on bullet points

Then I used flutter_widget_from_html and it's work as you can see on the given screenshot

System

Device: Redmi 8A
OS: Android 9.0

Screenshot:

Screenshot

Please let me know anything want to update or change

Thanks :)

@brunobowden brunobowden linked a pull request Jan 7, 2021 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-ui Client user interface P2 "Nice to have" - shipping next version without this will not have a major impact source:qa From QA team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants