Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mockito with mocktail #427

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

sourcegraph-wk
Copy link

In order to help with build times and ease null safety migration, we've opted to replace mockito with mocktail. This batch runs the codemod to swap things out, but may require manual intervention.
FEDX will come around and fix things up unless you beat us to it. Once CI is green and the PR is not in draft, you can review and merge it.
For more info, reach out to #support-frontend-dx on Slack.

Created by Sourcegraph batch change Workiva/mocktail.

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@sourcegraph-wk sourcegraph-wk force-pushed the batch/fedx/mocktail/w_transport branch from 8098c67 to 5d466a7 Compare April 25, 2024 21:54
@sourcegraph-wk sourcegraph-wk force-pushed the batch/fedx/mocktail/w_transport branch from 5d466a7 to ba36845 Compare April 26, 2024 05:02
@tusharmathur-wk tusharmathur-wk self-assigned this May 10, 2024
@tusharmathur-wk tusharmathur-wk marked this pull request as ready for review May 10, 2024 11:24
Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 CI passes w/ mocktail instead of mockito @Workiva/release-management-p

@robbecker-wf
Copy link
Member

@aviary3-wk

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit 5d5671c into master May 13, 2024
4 checks passed
@rm-astro-wf rm-astro-wf deleted the batch/fedx/mocktail/w_transport branch May 13, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants