FEA-1797: Bug fix for the send method's body param on fall through requests
#393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
rm-astro-wf
changed the title
send method's body param on fall through requestssend method's body param on fall through requests
bender-wk
changed the title
send method's body param on fall through requestssend method's body param on fall through requests
maxwellpeterson-wf
approved these changes
Apr 26, 2023
|
QA +1 |
rmconsole2-wf
deleted the
fix-send-body-param-with-fall-through-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using
MockTransports.install(fallThrough: true), each request (when.send()is called) is checked against the mocks configured at that time. If no matching mocks are found, the request "falls through" and is converted to a real request. Thesend()method has an optionalbodyparameter that is lost in this specific corner case - when the request is converted to a real request, thebodyparameter is not being passed on.Changes
Forward on the
bodyparameter after switching to a real request.