AF-1899 Dart 2 compatibility #320
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on HipChat: InfoSec Forum. |
evanweible-wf
force-pushed
the
dart2
branch
3 times, most recently
from
06b01db to
a24c87c
Compare
evanweible-wf
force-pushed
the
dart2
branch
3 times, most recently
from
0ee48f0 to
bdb6d3b
Compare
.travis.yml
Outdated
| @@ -17,33 +17,34 @@ stages: | |||
| jobs: | |||
| include: | |||
| - stage: quality | |||
| dart: stable | |||
There was a problem hiding this comment.
let's include 1.24.3 and stable
pubspec.yaml
Outdated
| @@ -28,29 +28,24 @@ dependencies: | |||
| sockjs_client: | |||
| git: | |||
| url: git://github.com/Workiva/sockjs-dart-client.git | |||
| ref: 0.3.3 | |||
| sockjs_client_wrapper: ^1.0.4 | |||
| ref: 0.3.4 | |||
There was a problem hiding this comment.
sockjs_client 0.3.5 is released that is dart2 compatible.
pubspec.yaml
Outdated
| ref: 0.3.3 | ||
| sockjs_client_wrapper: ^1.0.4 | ||
| ref: 0.3.4 | ||
| sockjs_client_wrapper: ^1.0.5 | ||
|
|
||
| dev_dependencies: | ||
| browser: ^0.10.0+2 |
There was a problem hiding this comment.
need to remove browser and replace .dart with .dart.js in html files to load the compiled JS always.
html files to update:
|
So close to ready for dart 2. Just need a few fixes and a dart 2 compatible dart_dev and were there. |
# Conflicts: # Dockerfile
evanweible-wf
force-pushed
the
dart2
branch
2 times, most recently
from
5f0dee4 to
9cc5513
Compare
| Dart 2: TBD | ||
|
|
There was a problem hiding this comment.
Can we just say pub run build_runner serve example here ?
There was a problem hiding this comment.
Yes, but we will also need to upgrade to the version of over_react that eventually includes builder support. That's mainly why I was leaving this as TBD since the examples just won't work on Dart 2 right now
There was a problem hiding this comment.
imo, we should create a ticket for this change so it doesn't get lost in the dart 2 work.
| Dart 2: TBD | ||
|
|
There was a problem hiding this comment.
imo, we should create a ticket for this change so it doesn't get lost in the dart 2 work.
|
+10 CI passes under dart 1 and dart 2 |
|
Quality Review Approval: +1 ( aka QA: +1 )
Merging into master. |
Description
Update w_transport to be compatible with Dart 2 and make sure CI is running on both Dart 1 and 2 (dev).
Testing
Code Review
@Workiva/app-frameworks
@robbecker-wf