AF-1690 Copy content-type/length on mock-aware fall-through #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on HipChat: InfoSec Forum. |
evanweible-wf
commented
Jul 19, 2018
| @@ -462,7 +465,7 @@ abstract class CommonRequest extends Object | |||
| /// a real request instance (created from a TransportPlatform instance). | |||
| /// | |||
| /// This is handled by the mock request mixin. | |||
| Future<BaseResponse> switchToRealRequest({bool streamResponse}) { | |||
There was a problem hiding this comment.
I changed this signature so that I could test switchToRealRequest directly.
evanweible-wf
commented
Jul 19, 2018
| if (this is! MultipartRequest) { | ||
| realRequest.encoding = encoding; | ||
| } | ||
|
|
||
| return streamResponse | ||
| ? realRequest.streamSend(method) | ||
| : realRequest.send(method); |
There was a problem hiding this comment.
This part is just moved to CommonRequest class above.
sebastianmalysa-wf
approved these changes
Jul 19, 2018
|
QA +1 this resolves the use case for which I reported the bug! thanks |
|
@Workiva/release-management-pp |
rmconsole4-wk
deleted the
copy_content_type_and_length_on_mock_aware_fall_through
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
MockTransportsare installed, requests are wrapped in a "mock-aware" class when constructed. WhenfallThrough: true, these requests will switch to real requests if there isn't an applicable handler/expectation. This is achieved by constructing a new request instance with the real transport platform on demand and copying all of the request properties over from the mock-aware wrapper to the real request.We weren't copying the
contentTypeandcontentLengthproperties. If a consumer had explicitly set one of these properties (rare, but does happen), they would not be copied over in this scenario.Solution
Be sure to also copy
contentType(only if it was explicitly set) andcontentLengthwhen switching from a mock-aware request to a real request.Testing
Code Review
@Workiva/app-frameworks
@travissanderson-wf