AF-157 don't add repeated data #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbeckman-wf
changed the title
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on HipChat: InfoSec Forum. |
| @@ -0,0 +1,70 @@ | |||
| // Copyright 2018 Workiva Inc. | |||
There was a problem hiding this comment.
Let's just put this directly in the test/unit/http/ dir instead of a browser/ subdir. There's already one other file that only runs in the browser and the @TestOn() annotation + the browser in the test file name communicates that requirement effectively.
evanweible-wf
requested changes
May 10, 2018
evanweible-wf
approved these changes
May 16, 2018
dustinlessard-wf
approved these changes
May 16, 2018
|
|
||
| final FormDataBody body = await request.finalizeBody(); | ||
| final List<Blob> blobs = body.formData.getAll(key); | ||
| expect(blobs.length, equals(1)); |
There was a problem hiding this comment.
tests are failing on the dart2 dev channel because the return type for formData.getAll() is List<Object>, so the typing of List<Blob> fails strong mode.
Need to change this to something like:
final FormDataBody body = await request.finalizeBody();
expect(body.formData.getAll(key), hasLength(1));… into AF-157_repeated-data
evanweible-wf
approved these changes
May 16, 2018
maxwellpeterson-wf
approved these changes
May 16, 2018
|
+10
QA +1
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
FormData was getting added to the request twice.
Solution
Don't add it twice.
Testing Suggestion